Vamsi-klu commented on PR #19087: URL: https://github.com/apache/pinot/pull/19087#issuecomment-5200068610
Thanks for the pointer. I went through #18816 and agree it addresses #16317 via the opt-in sourceFieldConfigs. This branch actually builds on that machinery rather than adding a parallel path (it extends addSourceFieldDataTypeTransformer and reuses the Map based DataTypeTransformer constructor). The remaining delta is zero config behavior: when an aggregation source column like SUM(col1) AS col2 is not in the schema and has no explicit SourceFieldConfig, the type is auto derived from the aggregation function and destination metric, so users hit the conversion by default instead of needing to know about sourceFieldConfigs. Explicit SourceFieldConfig still takes precedence, and COUNT/HLL/sketch sources are left unconverted. If you prefer keeping conversion strictly explicit, I am happy to close this. Otherwise I can rework it as a small follow up on top of #18816. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
