Vamsi-klu commented on code in PR #19083:
URL: https://github.com/apache/pinot/pull/19083#discussion_r3725703100
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java:
##########
@@ -178,6 +178,18 @@ private CommittingSegmentDescriptor
createCommittingSegmentDescriptor(String seg
return createCommittingSegmentDescriptor(segmentName, NEXT_OFFSET);
}
+ /**
+ * Test cases for new table being created, and initial segments setup that
follows.
+ */
+
+ /**
+ * Test cases for new table being created, and initial segments setup that
follows.
+ */
+
+ /**
+ * Test cases for new table being created, and initial segments setup that
follows.
+ */
+
Review Comment:
Good catch, thanks. These duplicate Javadoc blocks were accidentally
introduced in this PR at all six spots (the same section header ends up
repeated four times in each place). I will remove the extra copies and keep a
single Javadoc per test section in the next push.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2535,6 +2647,21 @@ private boolean isTmpAndCanDelete(String filePath,
Set<String> downloadUrls, Pin
return getCurrentTimeMs() - lastModified >
_controllerConf.getTmpSegmentRetentionInSeconds() * 1000L;
}
+ /**
+ * Reset consumption start offsets for selected partition groups (issue
#6637).
+ * For each partition: OFFLINE the latest CONSUMING segment if needed, then
create a new IN_PROGRESS
+ * consuming segment at the requested offset. Does not attempt to
seal/commit poisoned segments.
+ *
+ * <p>Best-effort per partition: successes and failures are returned
independently. Concurrent RSVM/commit
+ * races and pauseless edge cases are not fully serialized yet (IdealState
is written via {@link #setIdealState},
+ * not Helix CAS — callers must avoid concurrent commits on the same
partitions).
+ *
+ * @param tableNameWithType realtime table name with type
+ * @param partitionToOffsetSerialized map of partition group id → serialized
{@link StreamPartitionMsgOffset}
+ * @param comment optional operator comment for logs (newlines stripped)
+ * @return per-partition result maps with keys
status/oldSegment/newSegment/offset/message
+ */
+
Review Comment:
Thanks, agreed. That reset-offsets Javadoc block does not belong to any
method in this file and was added by mistake right above forceCommit, which
already has its own Javadoc. I will delete the stray block in the next push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
