J-HowHuang opened a new pull request, #19176:
URL: https://github.com/apache/pinot/pull/19176

   ## Description
   Originally the disk utilization precheck in table rebalance is easily 
confusing. Reduce the unnecessary information so that it's more intuitive.
   
   ## Original Behavior
   * Precheck `diskUtilizationDuringRebalance`: shows the highest disk 
utilization on each server it could get during the rebalance (i.e. the 
footprint, the worst case if all segments are added first, then removed)
   * Precheck `diskUtilizationAfterRebalance`: shows the net disk utilization 
on each server after rebalance
   
   These checks warn anyway regardless of `lowDiskMode` is set or not, where 
the `lowDiskMode` config is designed to solve the case when the first fails and 
the second passes.
   
   ## New Behavior
   Make it only one `diskUtilization` check. Pass when both the original 
`diskUtilizationDuringRebalance` and `diskUtilizationAfterRebalance` passes, or 
only `diskUtilizationAfterRebalance` passes yet `lowDiskMode=true, 
downtime=false`, fail otherwise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to