xiangfu0 commented on code in PR #19177:
URL: https://github.com/apache/pinot/pull/19177#discussion_r3733227482
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/SegmentMetadataImpl.java:
##########
@@ -420,18 +419,19 @@ public void setZkCreationTime(long zkCreationTime) {
_zkCreationTime = zkCreationTime;
}
- /// Returns the ZooKeeper push time for upsert consistency.
- /// This refers to the time set by controller while pushing the segment. It
is used to ensure consistent
- /// push time across replicas for upsert operations.
- /// @return ZK push time in milliseconds, or Long.MIN_VALUE if not set
+ /// @deprecated ZK push time is no longer used for upsert; offline upsert
now requires an explicit comparison
+ /// column (or the table's time column), same as realtime. Retained as a
no-op returning `Long.MIN_VALUE` for
+ /// binary compatibility with the 1.5.x SPI and slated for removal in a
future release.
+ @Deprecated
public long getZkPushTime() {
- return _zkPushTime;
+ return Long.MIN_VALUE;
}
- /// Sets the ZooKeeper push time for upsert consistency.
- /// @param zkPushTime ZK push time in milliseconds
+ /// @deprecated ZK push time is no longer used for upsert; see
[#getZkPushTime()]. Retained as a no-op for binary
+ /// compatibility with the 1.5.x SPI and slated for removal in a future
release.
Review Comment:
This comment targets an earlier revision of the PR. The
`SegmentMetadataImpl` change (the deprecated no-op
`getZkPushTime()`/`setZkPushTime()` methods and this doc comment) has since
been removed — the file was reverted to master because the ZK push-time
plumbing is orthogonal to the comparison-column rollback this PR is scoped to.
No such doc comment remains in the current diff, so there is nothing to fix
here.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
