goutamadwant opened a new pull request, #19178:
URL: https://github.com/apache/pinot/pull/19178

   ## Summary
   
   - keep server readiness endpoints unavailable until the query-serving path 
is ready
   - reuse the server's existing local readiness state, which becomes ready 
after the query server starts and `IS_SHUTDOWN_IN_PROGRESS` is cleared
   - preserve liveness behavior and add regression coverage for the startup 
window
   
   ## Why
   
   During startup, `ServiceStatus` can become `GOOD` before the query server is 
started and before brokers can route queries back to the server. This allowed 
`/health` and `/health/readiness` to return `200` too early during rolling 
restarts.
   
   The health resource uses the existing local readiness signal instead of 
reading Helix on every probe.
   
   This addresses item 1 of #16565. The broker external-view watermark 
described in item 2 remains out of scope.
   
   ## Testing
   
   - `./mvnw -pl pinot-server -am 
-Dtest=HealthCheckResourceTest,AccessControlTest 
-Dsurefire.failIfNoSpecifiedTests=false test`
   - `./mvnw spotless:apply -pl pinot-server`
   - `./mvnw license:format -pl pinot-server`
   - `./mvnw checkstyle:check -pl pinot-server`
   - `./mvnw license:check -pl pinot-server`
   - `./mvnw test-compile -pl pinot-server -am 
-Dmaven.compiler.showDeprecation=true -Dmaven.compiler.showWarnings=true 
'-Dmaven.compiler.compilerArgs=-Xlint:all'`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to