Vamsi-klu commented on PR #19025: URL: https://github.com/apache/pinot/pull/19025#issuecomment-5249496835
You were right that it was related. The reworded comments I added to the test template YAML contained raw dollar signs, and `GroovyTemplateUtilsTest` and `IngestionJobLauncherTest` render that file through Groovy's SimpleTemplateEngine, which cannot parse a bare dollar sign. Reworded to avoid dollar signs and backslashes entirely, rebased onto latest master, pushed as `adc0b5f`. I checked it by replicating `GroovyTemplateUtils.renderTemplate` against the same Groovy and SnakeYAML jars and rendering all five `IngestionJobLauncherTest` context variants: master renders 5 of 5, the old PR head failed, and the new one is back to 5 of 5 with the asserted values unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
