Copilot commented on code in PR #19227:
URL: https://github.com/apache/pinot/pull/19227#discussion_r3768465189
##########
pinot-core/src/test/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionNullContractTest.java:
##########
@@ -253,7 +253,11 @@ public void
testValueFunctionsReturnNullWhenNothingAggregated() {
AggregationFunctionType.SUMLONG, AggregationFunctionType.SUMPRECISION,
AggregationFunctionType.FIRSTWITHTIME,
AggregationFunctionType.LASTWITHTIME, AggregationFunctionType.ARRAYAGG,
AggregationFunctionType.LISTAGG,
// Given the option so they can skip null rows; a row counts only when
both input columns are non-null
- AggregationFunctionType.COVARPOP, AggregationFunctionType.COVARSAMP
+ AggregationFunctionType.COVARPOP, AggregationFunctionType.COVARSAMP,
+ // Given the option so they can skip null rows. These two were in this
set once before, on the strength of an
+ // identity comparison that reported every serializer-valued function as
honouring it; they belong here now
+ // because they genuinely do.
+ AggregationFunctionType.FREQUENTSTRINGSSKETCH,
AggregationFunctionType.FREQUENTLONGSSKETCH
Review Comment:
This census only calls `aggregate` and stops at the first usable synthetic
shape (`STRING` for the strings sketch and `LONG` for the longs sketch). It
therefore does not exercise the newly rewritten `BYTES`, group-by SV, or
group-by MV null paths, including the claim that null serialized rows are not
deserialized. Please add focused regression tests with valid serialized
sketches and null bitmaps for these paths (covering enabled and disabled modes,
plus all-null/zero-length holder behavior).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
