J-HowHuang commented on code in PR #19221:
URL: https://github.com/apache/pinot/pull/19221#discussion_r3770395571
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -368,6 +464,30 @@ void refreshSegmentStates() {
}
_segmentStates = new SegmentStates(instanceCandidatesMap,
servingInstances, unavailableSegments);
+ _replicaHealth =
+ new SegmentReplicaHealth(minPercentOfReplicas,
numSegmentsWithoutRedundancy, unavailableSegments.size());
+ emitReplicaHealthMetrics(_replicaHealth);
Review Comment:
This is the TODO item of `BaseInstanceSelector` per se, skip in this PR
```
/// TODO: refresh new/old segment state where there is no update from helix
for long time.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
