shauryachats commented on code in PR #18855:
URL: https://github.com/apache/pinot/pull/18855#discussion_r3771228198
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentmetadata/SegmentZkMetadataFetcher.java:
##########
@@ -82,7 +85,11 @@ public void init(IdealState idealState, ExternalView
externalView, Set<String> o
listener.init(idealState, externalView, segments, znRecords);
}
for (int i = 0; i < numSegments; i++) {
- if (znRecords.get(i) != null) {
+ // Only cache segments that are both non-consuming in EV AND have a
committed ZNRecord.
+ // If a segment is ONLINE in EV but its ZNRecord still has
startTime=-1 (brief window between
Review Comment:
Verified you're right —
`PinotLLCRealtimeSegmentManager.commitSegmentMetadataInternal` persists the
ZNRecord before updating IdealState, and EV is Helix-derived only afterward
(same for remote clusters, which use a direct spectator HelixManager with no
proxy), so dropped the `startTime >= 0` check and kept only the `znRecord !=
null` guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
