Jackie-Jiang commented on code in PR #19251:
URL: https://github.com/apache/pinot/pull/19251#discussion_r3778951198
##########
pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java:
##########
@@ -150,6 +151,52 @@ public enum ControllerResponseStatus {
// (like size reaching close to its limit or number of col values for a col
is about to overflow int max)
public static final String REASON_INDEX_CAPACITY_THRESHOLD_BREACHED =
"indexCapacityThresholdBreached";
+ public enum ReasonCode {
+ ROW_LIMIT(REASON_ROW_LIMIT),
Review Comment:
I feel the purpose is to add an integer response code instead of a string
enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]