tarun11Mavani commented on code in PR #19041:
URL: https://github.com/apache/pinot/pull/19041#discussion_r3797109413
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/openstruct/MutableOpenStructIndex.java:
##########
@@ -162,7 +171,9 @@ private Object tryCoerce(String key, Object rawValue,
DataType storedType) {
} catch (Exception e) {
ServerMetrics serverMetrics = ServerMetrics.get();
if (serverMetrics != null) {
-
serverMetrics.addMeteredGlobalValue(ServerMeter.OPEN_STRUCT_TYPE_COERCION_FAILURES,
1);
+ serverMetrics.addMeteredTableValue(_tableNameWithType,
+ OpenStructNaming.materializedColumnName(_openStructColumn, key),
+ ServerMeter.OPEN_STRUCT_TYPE_COERCION_FAILURES, 1);
Review Comment:
Make sense. Both meters are now column-granular
(`addMeteredTableValue(_tableNameWithType, _openStructColumn, ...)`), no
per-key registration in this file anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
