Jackie-Jiang commented on code in PR #19216:
URL: https://github.com/apache/pinot/pull/19216#discussion_r3800147442
##########
pinot-common/src/main/java/org/apache/pinot/common/function/sql/PinotSqlFunction.java:
##########
@@ -28,12 +28,25 @@
/// Pinot custom SqlFunction to be registered into SqlOperatorTable.
public class PinotSqlFunction extends SqlFunction {
private final boolean _deterministic;
+ private final boolean _volatile;
public PinotSqlFunction(String name, SqlReturnTypeInference
returnTypeInference,
- SqlOperandTypeChecker operandTypeChecker, boolean deterministic) {
+ SqlOperandTypeChecker operandTypeChecker, boolean deterministic, boolean
isVolatile) {
Review Comment:
(nit)
```suggestion
SqlOperandTypeChecker operandTypeChecker, boolean deterministic,
boolean volatile) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
