Jackie-Jiang commented on code in PR #19297:
URL: https://github.com/apache/pinot/pull/19297#discussion_r3817150307
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/ExactVectorScanFilterOperator.java:
##########
@@ -90,12 +94,21 @@ public ExactVectorScanFilterOperator(ForwardIndexReader<?>
forwardIndexReader,
public ExactVectorScanFilterOperator(ForwardIndexReader<?>
forwardIndexReader,
VectorSimilarityPredicate predicate, String column, int numDocs,
@Nullable VectorIndexConfig vectorIndexConfig,
String fallbackReason, VectorSearchParams searchParams) {
+ this(forwardIndexReader, predicate, column, numDocs, vectorIndexConfig,
fallbackReason, searchParams, null);
+ }
+
+ /// Creates an exact scan restricted to a mandatory query-owned candidate
scope.
+ public ExactVectorScanFilterOperator(ForwardIndexReader<?>
forwardIndexReader,
Review Comment:
We got too many constructors, where only the main one is used in production.
Let's just keep one constructor and make test put all the arguments
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/ExactVectorScanFilterOperator.java:
##########
@@ -90,12 +94,21 @@ public ExactVectorScanFilterOperator(ForwardIndexReader<?>
forwardIndexReader,
public ExactVectorScanFilterOperator(ForwardIndexReader<?>
forwardIndexReader,
VectorSimilarityPredicate predicate, String column, int numDocs,
@Nullable VectorIndexConfig vectorIndexConfig,
String fallbackReason, VectorSearchParams searchParams) {
+ this(forwardIndexReader, predicate, column, numDocs, vectorIndexConfig,
fallbackReason, searchParams, null);
+ }
+
+ /// Creates an exact scan restricted to a mandatory query-owned candidate
scope.
+ public ExactVectorScanFilterOperator(ForwardIndexReader<?>
forwardIndexReader,
Review Comment:
Is this used? Seems there is no change to `FilterPlanNode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
