Akanksha-kedia commented on PR #18920: URL: https://github.com/apache/pinot/pull/18920#issuecomment-5365649786
@J-HowHuang added `BaseIndexHandlerTest` covering all the corner cases you asked about: - Null properties (in-memory segment) → returns null - Missing key (legacy segment) → returns null - Round-trip in-memory (default config + non-default config) - Round-trip through disk (write → save → reload → read) - Special characters in serialized JSON (colons, quotes) round-trip via escaping - Corrupt/undeserializable stored value → null, no exception - Multiple columns under the same key don't interfere - `loadMetadataProperties()` returns non-null for a file-backed segment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
