codecov-commenter commented on PR #19380: URL: https://github.com/apache/pinot/pull/19380#issuecomment-5451590386
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `92.09454%` with `97 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.72%. Comparing base ([`5e914c9`](https://app.codecov.io/gh/apache/pinot/commit/5e914c979b355c0e8c9fd4cd6f401f5f899594b5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`935299a`](https://app.codecov.io/gh/apache/pinot/commit/935299a8f6882708d67d8fe69c79733313e3ca98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/19380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...gation/groupby/offheap/OffHeapBytesGroupIdMap.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapBytesGroupIdMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcEJ5dGVzR3JvdXBJZE1hcC5qYXZh) | 91.01% | [12 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pby/NoDictionarySingleColumnGroupKeyGenerator.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2FNoDictionarySingleColumnGroupKeyGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L05vRGljdGlvbmFyeVNpbmdsZUNvbHVtbkdyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | 92.25% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ry/aggregation/groupby/DefaultGroupByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2FDefaultGroupByExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RlZmF1bHRHcm91cEJ5RXhlY3V0b3IuamF2YQ==) | 67.74% | [7 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...tion/groupby/offheap/OffHeapGroupByBufferPool.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapGroupByBufferPool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcEdyb3VwQnlCdWZmZXJQb29sLmphdmE=) | 83.33% | [6 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...regation/groupby/offheap/OffHeapIntGroupIdMap.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapIntGroupIdMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcEludEdyb3VwSWRNYXAuamF2YQ==) | 94.96% | [2 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...egation/groupby/offheap/OffHeapLongGroupIdMap.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapLongGroupIdMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcExvbmdHcm91cElkTWFwLmphdmE=) | 95.17% | [2 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pby/offheap/ResourceTrackingGroupKeyGenerator.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FResourceTrackingGroupKeyGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvUmVzb3VyY2VUcmFja2luZ0dyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | 79.31% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...t/core/operator/query/FilteredGroupByOperator.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Foperator%2Fquery%2FFilteredGroupByOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9GaWx0ZXJlZEdyb3VwQnlPcGVyYXRvci5qYXZh) | 42.85% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../core/operator/combine/GroupByCombineOperator.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Foperator%2Fcombine%2FGroupByCombineOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9jb21iaW5lL0dyb3VwQnlDb21iaW5lT3BlcmF0b3IuamF2YQ==) | 85.71% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/pinot/core/operator/query/GroupByOperator.java](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Foperator%2Fquery%2FGroupByOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9Hcm91cEJ5T3BlcmF0b3IuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [8 more](https://app.codecov.io/gh/apache/pinot/pull/19380?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #19380 +/- ## ============================================ + Coverage 67.55% 67.72% +0.16% Complexity 1430 1430 ============================================ Files 3486 3495 +9 Lines 224100 225273 +1173 Branches 35370 35560 +190 ============================================ + Hits 151392 152556 +1164 + Misses 60678 60659 -19 - Partials 12030 12058 +28 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-25](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.72% <92.09%> (+0.16%)` | :arrow_up: | | [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | | | [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.72% <92.09%> (+0.16%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.71% <92.09%> (+0.16%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.95% <92.09%> (+0.31%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.12% <0.97%> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19380?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
