xiangfu0 opened a new pull request, #19387: URL: https://github.com/apache/pinot/pull/19387
## Summary Make the static asynchronous ZooKeeper disconnector use a daemon worker thread. The executor is process-scoped and intentionally has no shutdown path, so its worker must not keep short-lived Pinot tools, tests, or benchmark forks alive after their useful work finishes. ## How to reproduce 1. Start a JVM that invokes `ZkStarter.closeAsync(...)` or starts/stops a local ZooKeeper instance. 2. Allow the main application work and every other non-daemon thread to finish. 3. Observe that the JVM remains alive because the static `zk-disconnector` fixed-pool worker is non-daemon. With this change, the queued close still runs, but the idle worker no longer prevents natural JVM shutdown. ## Validation - `ZkStarterTest.testAsyncCloserUsesDaemonThread` verifies that the asynchronous close executes on a daemon worker - formatting, Checkstyle, and license checks for `pinot-common` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
