deepthi912 opened a new pull request, #19391:
URL: https://github.com/apache/pinot/pull/19391
## Summary
\`IndexLoadingConfig\` already merges tier overrides via
\`getTableConfigWithTierOverwrites()\`, and every other index-related getter
routes through that merged view. But \`isSkipSegmentPreprocess()\` was still
reading the raw \`_tableConfig\` directly, so a tier override like
\`\`\`json
"tableIndexConfig": {
"skipSegmentPreprocess": true,
"tierOverwrites": {
"preprocessed": { "skipSegmentPreprocess": false }
}
}
\`\`\`
parsed and stored correctly but had no effect on preprocess decisions.
This one-line fix routes the getter through the tier-merged view so the flag
can be flipped per tier, matching the surrounding index config getters. Enables
patterns like "skip preprocess on the hot tier, run it on the cold tier."
## Changes
- \`IndexLoadingConfig.isSkipSegmentPreprocess()\` reads via
\`getTableConfigWithTierOverwrites()\` instead of directly from
\`_tableConfig\`.
- Added \`testSkipSegmentPreprocessRespectsTierOverwrites\` covering default
tier, unknown tier, tier with override, and clearing the tier back to default.
## Test plan
- [x] \`./mvnw -pl pinot-segment-local test -Dtest=IndexLoadingConfigTest\`
— all 4 tests pass
- [x] \`./mvnw -pl pinot-segment-local checkstyle:check spotless:check\` —
clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
