xiangfu0 commented on PR #19307: URL: https://github.com/apache/pinot/pull/19307#issuecomment-5466065501
Addressed in `4a138bca8e`. - Reduced the PR by removing eight dedicated/integration test classes. The retained V7 coverage is centered on one real creator-to-reader forward-index round trip in the existing factory test, plus one compact real reload-transition method and one table-validation method. No new mocks were added. - Resolved all 10 review threads: writer-owned V7 versioning, override annotations, `FixedByteChunkWriter` naming, reusable bounded encode/decode scratch, generic rewrite naming, header-only reload inspection, V7-specific scratch ownership, bounded canonical plan caching, and remove-only rollback coverage. - Final local validation: 229 focused tests pass; Spotless, Checkstyle, and license gates pass for both affected modules. - Matched V7 ingestion JMH (`DELTA,ZSTD(3)`): 14.511 to 12.296 ms/op (15.3% faster), with zero GC in both runs. The branch is rebased on current `master` and squashed to one commit. Please re-review when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
