codecov-commenter commented on PR #19402: URL: https://github.com/apache/pinot/pull/19402#issuecomment-5475373373
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19402?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `89.92193%` with `142 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.05%. Comparing base ([`5e914c9`](https://app.codecov.io/gh/apache/pinot/commit/5e914c979b355c0e8c9fd4cd6f401f5f899594b5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ffec9cd`](https://app.codecov.io/gh/apache/pinot/commit/ffec9cdc1255e30453b810acf1e6860be74ce8cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 10 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/19402?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../function/DistinctCountULLAggregationFunction.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2FDistinctCountULLAggregationFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdENvdW50VUxMQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | 43.39% | [28 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...gation/groupby/offheap/OffHeapBytesGroupIdMap.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapBytesGroupIdMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcEJ5dGVzR3JvdXBJZE1hcC5qYXZh) | 91.01% | [12 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...offheap/OffHeapUltraLogLogGroupByResultHolder.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapUltraLogLogGroupByResultHolder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcFVsdHJhTG9nTG9nR3JvdXBCeVJlc3VsdEhvbGRlci5qYXZh) | 87.70% | [10 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pby/NoDictionarySingleColumnGroupKeyGenerator.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2FNoDictionarySingleColumnGroupKeyGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L05vRGljdGlvbmFyeVNpbmdsZUNvbHVtbkdyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | 92.25% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ry/aggregation/groupby/DefaultGroupByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2FDefaultGroupByExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RlZmF1bHRHcm91cEJ5RXhlY3V0b3IuamF2YQ==) | 72.97% | [7 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...tion/groupby/offheap/OffHeapGroupByBufferPool.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapGroupByBufferPool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcEdyb3VwQnlCdWZmZXJQb29sLmphdmE=) | 83.33% | [6 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...regation/groupby/offheap/OffHeapIntGroupIdMap.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapIntGroupIdMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcEludEdyb3VwSWRNYXAuamF2YQ==) | 94.96% | [2 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...egation/groupby/offheap/OffHeapLongGroupIdMap.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FOffHeapLongGroupIdMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvT2ZmSGVhcExvbmdHcm91cElkTWFwLmphdmE=) | 95.17% | [2 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pby/offheap/ResourceTrackingGroupKeyGenerator.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Fgroupby%2Foffheap%2FResourceTrackingGroupKeyGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L29mZmhlYXAvUmVzb3VyY2VUcmFja2luZ0dyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | 79.31% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...t/core/operator/query/FilteredGroupByOperator.java](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Foperator%2Fquery%2FFilteredGroupByOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9GaWx0ZXJlZEdyb3VwQnlPcGVyYXRvci5qYXZh) | 42.85% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [10 more](https://app.codecov.io/gh/apache/pinot/pull/19402?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | > :exclamation: There is a different number of reports uploaded between BASE (5e914c9) and HEAD (ffec9cd). Click for more details. > > <details><summary>HEAD has 24 uploads less than BASE</summary> > >| Flag | BASE (5e914c9) | HEAD (ffec9cd) | >|------|------|------| >|unittests|2|1| >|java-25|6|1| >|temurin|6|1| >|lane-a|2|0| >|integration|4|0| >|integration2|2|0| >|lane-b|2|0| >|integration1|2|0| >|unittests2|1|0| ></details> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #19402 +/- ## ============================================ - Coverage 67.55% 58.05% -9.51% + Complexity 1430 1 -1429 ============================================ Files 3486 2693 -793 Lines 224100 165302 -58798 Branches 35370 26841 -8529 ============================================ - Hits 151392 95958 -55434 - Misses 60678 61306 +628 + Partials 12030 8038 -3992 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-25](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.05% <89.92%> (-9.51%)` | :arrow_down: | | [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.05% <89.92%> (-9.51%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.05% <89.92%> (-9.51%)` | :arrow_down: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.05% <89.92%> (+0.40%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19402?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
