Jackie-Jiang commented on code in PR #19399:
URL: https://github.com/apache/pinot/pull/19399#discussion_r3908884320
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -970,6 +998,9 @@ private void addNewRow(int docId, GenericRow row) {
MutableIndex mutableIndex = indexEntry.getValue();
mutableIndex.add(values, dictIds, docId);
updateIndexCapacityThresholdBreached(mutableIndex,
indexEntry.getKey(), column);
+ } catch (IllegalArgumentException e) {
+ // Row-limit violations must fail the document. Other index errors
stay fail-soft (#16316).
Review Comment:
I might merge the PR pre-maturely. What happens when we throw the exception
out? Does it abort the ingestion? The contract should be to honor the
`continueOnError` flag, and handle it when the flag is set to `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
