xiangfu0 commented on PR #19397: URL: https://github.com/apache/pinot/pull/19397#issuecomment-5519222007
Rebased and updated at `64edf3219378`. All four current review requests are addressed: 1. Removed the process-wide plan/alias cache and its three cache-only tests; `create()` is again pure parse/validate and lifecycle owners retain immutable executors. 2. Decode now calls the shared `encodedStageBounds()` helper and uses its returned composed bound. 3. Renamed the decode-only destination contract and related state to `requiresDirectDecodeDstBuffer()`. 4. Renamed `maxIntermediateSize` to `maxStageSize` consistently in the public decode API, messages, callers, and tests. The three older inline threads remain resolved. Fresh validation is 309 focused tests, all four module hygiene gates, and an independent eight-domain review with no remaining findings. Please re-review when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
