akg268 commented on PR #19251: URL: https://github.com/apache/pinot/pull/19251#issuecomment-5563007179
Addressed the follow-ups from the approval review in 6122087bed: - bound the REST reasonCode params as nullable Integer values before converting with ReasonCode.fromCode(int) - strengthened the force-commit reason-code threshold test with a positive row count - added a paired non-force reason-code test to show normal size tuning still happens - added class-level coverage context for LLCSegmentCompletionHandlersTest and switched to static TestNG assertions Local verification: - git diff --check passed - ./mvnw -pl pinot-common,pinot-controller checkstyle:check -DskipTests -Denforcer.skip=true passed with 0 violations in both modules - ./mvnw -pl pinot-common,pinot-controller -Dtest=SegmentCompletionProtocolTest,LLCSegmentCompletionHandlersTest,SizeBasedSegmentFlushThresholdComputerTest test reached the JDK gate and stopped because this machine has Java 21 while Pinot now requires JDK 25 - retrying with -Denforcer.skip=true and -am passed SegmentCompletionProtocolTest, then stopped when an upstream dependency compiled with release 25, which Java 21 does not support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
