shounakmk219 commented on code in PR #19278:
URL: https://github.com/apache/pinot/pull/19278#discussion_r3946892558
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -459,6 +460,18 @@ public static long getRandomInitialDelayInSeconds() {
public static final String CONFIG_OF_MAX_RELOAD_SEGMENT_JOBS_IN_ZK =
"controller.reload.segment.maxJobsInZK";
public static final String CONFIG_OF_MAX_FORCE_COMMIT_JOBS_IN_ZK =
"controller.force.commit.maxJobsInZK";
+ // Knobs governing how long endReplaceSegments blocks while waiting for the
new segments to become
+ // ONLINE in the ExternalView (IdealState -> ExternalView convergence). The
per-attempt wait is
+ // retried up to the configured number of attempts, so the worst-case block
is
+ // maxWaitMs * maxRetryAttempts. Defaults preserve the historical hard-coded
values.
Review Comment:
Trying not to change any existing defaults to keep the scope to only make
them configurable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
