scottlan0113 commented on issue #19388: URL: https://github.com/apache/pinot/issues/19388#issuecomment-5626371981
Closing this out. The two extension points this proposal needed have landed upstream — #19438 (`create*CombineOperator` on `CombinePlanNode`) and #19461 (`createCombinePlanNode` on `InstancePlanMakerImplV2`) — so an alternative combine table can now be plugged in without changes to `GroupByCombineOperator` or `GroupByUtils`. The sharded off-heap table itself is continuing as a plug-in built on those points rather than as an OSS change, so there is nothing further to track here. The linked doc stays as the record of the prototype comparison. Thanks for the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
