deepthi912 commented on code in PR #19504:
URL: https://github.com/apache/pinot/pull/19504#discussion_r3985299038
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -685,10 +685,12 @@ public void replaceSegment(ImmutableSegment segment,
@Nullable ThreadSafeMutable
revertSegmentUpsertMetadata(oldSegment, segmentName,
validDocIdsForOldSegment);
return;
}
- _logger.warn("Found {} primary keys not replaced for segment: {}",
- validDocIdsForOldSegment.getCardinality(), segmentName);
- updateInconsistentRowsMetric(segmentName,
validDocIdsForOldSegment.getCardinality());
- removeSegment(oldSegment, validDocIdsForOldSegment);
+ int numKeysStillNotReplaced =
+ removeSegmentAndGetNumKeysRemoved(oldSegment,
validDocIdsForOldSegment);
+ if (numKeysStillNotReplaced > 0) {
Review Comment:
How would this give us information about the keys that are not replaced?
validDocIdsForOldSegment will be gone down to 0 here if
`shouldRevertMetadataOnInconsistency` is false right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
