xiangfu0 opened a new pull request, #19541: URL: https://github.com/apache/pinot/pull/19541
Agent guidance could turn small changes into full review pipelines, repeat valid checks, stop for routine authorized work, and follow stale build or CI commands. This update scopes review and validation to the changed behavior, available evidence, and the requested task. - Consolidate shared guidance and shorten skill descriptions; retain the plugin module reference in `kb/plugin-modules.md`. - Select relevant review domains, classify findings by demonstrated impact, and use the actual pre-fix baseline for regression evidence. - Correct feature-flag defaults, scoped Maven validation, quickstart modes and readiness checks, CI workflow queries, and benchmark dependency handling and cleanup. Preserve applicable pre-push checks while allowing bounded asynchronous work and reuse of valid results. ### How to reproduce the instruction problems - Run `/precommit` before pushing committed changes from a clean working tree: the previous working-tree-only default could miss the delivery diff. - Review a multi-commit bug fix whose final commit only changes formatting: requiring failure on `HEAD~1` chooses a revision that already contains the fix. - Follow the previous flaky-test instructions: they query the removed `pinot_tests.yml` workflow instead of the current unit/integration workflows. ### Validation - `git diff --check` passed. - Checked 35 Markdown files, 57 local links, 14 YAML frontmatter blocks, settings JSON, and preservation of all 167 principle IDs; all passed. Five operational skill entry points passed the skill validator. - `./mvnw -N license:format license:check` passed with JDK 25: 46 files checked and no headers changed. - Commands, quickstart modes, workflow paths, and compiler properties checked against the current POMs, local plugin metadata, and relevant source. - Documentation only. Java formatting, Checkstyle, compilation, and runtime tests are not applicable to this diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
