Jackie-Jiang commented on code in PR #19010:
URL: https://github.com/apache/pinot/pull/19010#discussion_r4021484945
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -240,6 +240,10 @@ protected void revertAndRemoveSegment(IndexSegment segment,
}
// Revert to previous segment location
IndexSegment prevSegment = prevLocation.getSegment();
+ // Skip if prevSegment has been offloaded; its data buffers are
unmapped.
Review Comment:
Is this a bug fix? I don't think a check here is thread sage. Is there race
condition when the segment is offloaded after this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
