goutamadwant commented on code in PR #19178:
URL: https://github.com/apache/pinot/pull/19178#discussion_r4033184225
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -911,6 +914,13 @@ public void start()
_serverInstance.startQueryServer();
_helixAdmin.setConfig(_instanceConfigScope,
Map.of(Helix.IS_SHUTDOWN_IN_PROGRESS, Boolean.toString(false)));
+ if
(_serverConf.getProperty(Server.CONFIG_OF_STARTUP_ENABLE_BROKER_ROUTING_CHECK,
+ Server.DEFAULT_STARTUP_ENABLE_BROKER_ROUTING_CHECK)) {
+ _brokerRoutingReadyChecker = createBrokerRoutingReadyChecker();
+ _brokerRoutingReadyChecker.start();
Review Comment:
Addressed the serialization concern with a synchronized check and removed
the async fanout/request executor. A single scheduled worker performs
sequential bounded probes, while health requests only read cached state so they
cannot block on broker I/O.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
