arunkumarucet commented on PR #19434: URL: https://github.com/apache/pinot/pull/19434#issuecomment-5708721969
Rebased onto latest master to resolve conflicts with #19378, which independently moved descriptor reads to a streamed `PinotFS.open()` (`ProtoBufUtils.openDescriptorFile`). This PR now builds on that method instead of carrying its own read path: `getDescriptor` reads through `openDescriptorFile`, and the previously-added standalone read helpers are gone. The two commits are squashed into one (`08718c8`) since the intermediate state no longer made sense on top of the upstream refactor — all review-fix content described in the threads above is unchanged and included. Still unique to this PR beyond #19378: the last-known-good fallback itself (resolve-before-promote, fetch-vs-invalid separation, generation-stamped publication, bounded weigher), the cluster config `pinot.server.protobuf.descriptor.fallback.enabled` + per-table `descriptorFileFallbackEnabled` override, and temp-tree cleanup on copy failure for the codegen jar path. Re-verified on the new base: pinot-protobuf 178/178 tests, the new pinot-spi listener tests, pinot-server compile, checkstyle and license clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
