pri1712 commented on code in PR #19011:
URL: https://github.com/apache/pinot/pull/19011#discussion_r4052788560
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -739,6 +746,10 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
} else if (routeInfo.isOffline()) {
// OFFLINE only
setTableName(serverBrokerRequest, offlineTableName);
+ if (skipExpiredRecords) {
+ handleSkipExpiredRecords(offlineTableConfig, schema, serverPinotQuery);
+ _queryOptimizer.optimize(serverPinotQuery, schema);
Review Comment:
one query i have is, is it okay to reoptimize here? @xiangfu0 ?
for a per table type retention field, this seems like the best place to put
it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
