abhiramaab commented on issue #19611: URL: https://github.com/apache/pinot/issues/19611#issuecomment-5761650347
I'd like to work on this. My plan is the minimal fix: in reloadSegment, acquire the segment lock before acquire(_segmentReloadSemaphore, ...), matching doReplaceSegment, with a try/finally so the lock is released if acquire is interrupted. I'll add a unit test covering the interleaving. Any preference between converging on that order vs. a shared helper that both paths call? Happy to take the latter if you'd rather prevent divergence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
