Jackie-Jiang opened a new pull request, #19635: URL: https://github.com/apache/pinot/pull/19635
## Summary `ValueReader#getPaddedString` has no callers. This PR removes it along with: - The `FixedByteValueReaderWriter` implementation, plus its `UTF_8` static import, which nothing else uses. - The `VarLengthValueReader` implementation, which only threw `UnsupportedOperationException`. - The protected `BaseImmutableDictionary#getPaddedString` helper, which also had no callers. `ValueReader` is in `pinot-segment-local`, not an SPI, and `FixedByteValueReaderWriter` / `VarLengthValueReader` are its only implementations. No on-disk or wire format changes. This touches lines next to the ones #19634 changes (which adds `ValueReader#readBytes` next to `getPaddedString`), so whichever merges second needs a trivial rebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
