Jackie-Jiang commented on code in PR #19571:
URL: https://github.com/apache/pinot/pull/19571#discussion_r4087876928
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -324,7 +388,24 @@ public String getSegmentTier() {
public void setSegmentTier(String segmentTier) {
_segmentTier = segmentTier;
- _dirty = true;
+ _resolvedIndexState = null;
Review Comment:
Small optimization: could `setSegmentTier()` return early when
`Objects.equals(_segmentTier, segmentTier)`? A direct call with the same tier
currently clears `_resolvedIndexState`, so the next read rebuilds the index
configs. The `with...` methods already avoid this on their paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
