deepthi912 commented on code in PR #19706:
URL: https://github.com/apache/pinot/pull/19706#discussion_r4138846779
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/CrcUtils.java:
##########
@@ -42,7 +42,9 @@ private CrcUtils() {
private static final Logger LOGGER = LoggerFactory.getLogger(CrcUtils.class);
private static final int BUFFER_SIZE = 65536;
private static final String CRC_FILE_EXTENSTION = ".crc";
- private static final List<String> DATA_FILE_EXTENSIONS =
Arrays.asList(".fwd", ".dict");
+ // Null vectors count as data, because a null is stored as the default value
in the forward index
+ private static final List<String> DATA_FILE_EXTENSIONS =
Review Comment:
Does it really matter if we don't include null vector into data crc? Also
how can we keep it backward compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
