xiangfu0 commented on PR #19796: URL: https://github.com/apache/pinot/pull/19796#issuecomment-6065267971
Thanks for the review @yashmayya! Good catch on the npm `11.11.0` duplication between the compatibility workflows and `<npmVersion>` in `pinot-controller/pom.xml`. Single-sourcing it (e.g. reading the version from the pom) adds more shell complexity than it's worth for a value that changes rarely, so I'm keeping it inline here to keep the change minimal. Happy to follow up with a dedup if we bump npm again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
