xiangfu0 commented on code in PR #19795: URL: https://github.com/apache/pinot/pull/19795#discussion_r4229476954
########## compatibility-verifier/tdigest-compatibility/generate-rank-errors.sh: ########## @@ -0,0 +1,67 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Regenerate with the pinned legacy utility and 3.3 jar, then compare all case keys, inputs and rank errors. +# Use --update to replace the checked-in reference after intentionally changing the seeded input corpus. +set -euo pipefail +# Match the unit-test workflow's Maven Central retry and connection settings, including standalone runs. +export MAVEN_OPTS="${MAVEN_OPTS:-} -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \ +-Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false" +TDIGEST_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)" +TDIGEST_BASELINE=f818bae6d75a91228eb3aac95c921bca4aeb2128 +TDIGEST_WORK="$TDIGEST_ROOT/pinot-segment-local/target/tdigest-rank-oracle" +TDIGEST_JAR_DIR="$TDIGEST_ROOT/pinot-segment-local/target/tdigest-legacy-reader" +TDIGEST_JAR="$TDIGEST_JAR_DIR/t-digest-3.3.jar" +TDIGEST_REFERENCE="$TDIGEST_ROOT/pinot-core/src/test/resources/data/tdigest-3.3-k1-rank-errors.csv" +mkdir -p "$TDIGEST_WORK" "$TDIGEST_JAR_DIR" +if ! git -C "$TDIGEST_ROOT" cat-file -e "$TDIGEST_BASELINE^{commit}" 2>/dev/null; then + # CI checks out shallow history. Fetch only the immutable public baseline; leave the worktree and POMs alone. + for TDIGEST_ATTEMPT in 1 2 3; do + if git -C "$TDIGEST_ROOT" -c http.lowSpeedLimit=1 -c http.lowSpeedTime=30 \ + fetch --no-tags --depth=1 https://github.com/apache/pinot.git "$TDIGEST_BASELINE"; then Review Comment: **Side effect on developer clones: `git fetch --depth=1` into a full clone writes `.git/shallow`, silently making the contributor's repository shallow.** The comment above assumes CI's shallow checkout, but when a contributor whose clone lacks the baseline commit runs the oracle locally, this fetch converts their full clone into a shallow one, breaking later `rev-list`/`describe`/push-history operations until they run `git fetch --unshallow`. Guard with `git rev-parse --is-shallow-repository` (only use `--depth=1` when already shallow), or drop `--depth` for non-CI runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
