xiangfu0 commented on PR #19800: URL: https://github.com/apache/pinot/pull/19800#issuecomment-6089902563
Addressed [this review](https://github.com/apache/pinot/pull/19800#pullrequestreview-5475272499) in [c4513289bd](https://github.com/apache/pinot/commit/c4513289bd160d84b1518a9a6c7e575a48284821). Removed the aggregate-name special cases and numeric-only restriction. Intermediate OBJECT aggregate keys now use lazy, cached native `extractFinalResult()` values, following SSE, while retaining the original mergeable rows. Group keys, scalar intermediates and already-final values keep their existing heap path; the no-trim early return remains. Moved extraction safety into the funnel implementations: all five window finalizers consume private queue copies, and bitmap/set counts use private cumulative intersections. The group-by extraction contract now documents preservation of intermediate information for later merging. The comparison boundary is explicit in the code and PR description: native trimming compares SUMPRECISION numerically as BigDecimal, raw HLL by cardinality, and histogram/funnel lists lexicographically. Final MSE output conversion still yields hexadecimal strings for raw HLL (downstream ORDER BY is lexical) and primitive arrays (generic downstream sorting remains unsupported). This follows SSE's approximate intermediate candidate ranking; it does not establish exact final MSE ORDER BY equivalence for converted outputs. Aligning those downstream semantics requires carrying aggregate ordering information through planning/exchanges, beyond this fix. Validation: 58 focused tests pass (41 MSE, 17 funnel); all seven new extraction/merge cases fail on the prior funnel implementations. Both affected modules pass all four formatting/checkstyle/license checks, with no compiler warnings on changed code. The pushed PR head is verified; hosted CI for this commit is queued/running, and human approval remains pending. The previous scalar SUM measurements do not cover the object/funnel path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
