yashmayya commented on code in PR #19804:
URL: https://github.com/apache/pinot/pull/19804#discussion_r4275760149
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/sql/fun/PinotOperatorTable.java:
##########
@@ -299,6 +299,12 @@ public static PinotOperatorTable instance(boolean
nullHandlingEnabled) {
OperandTypes.family(
List.of(SqlTypeFamily.CHARACTER, SqlTypeFamily.CHARACTER,
SqlTypeFamily.INTEGER), i -> i == 2)),
+ // IN_SUBQUERY(expr, 'subquery') never runs: the broker runs the
subquery first and replaces the call with an
+ // IN_ID_SET on the result. It is registered for the paths that only
compile queries, such as the controller
+ // routing a query to a broker. Nullable like IN_ID_SET.
+ new PinotSqlFunction("IN_SUBQUERY", ReturnTypes.BOOLEAN_NULLABLE,
Review Comment:
I'd prefer deferring this to later given it isn't a real bug right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
