deepthi912 commented on code in PR #19832: URL: https://github.com/apache/pinot/pull/19832#discussion_r4287011464
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ########## @@ -131,6 +131,9 @@ public abstract class BasePartitionUpsertMetadataManager implements PartitionUps // Used to maintain the largestSeenComparisonValue to avoid handling out-of-ttl segments/records. // If upsertTTL enabled, we will keep track of largestSeenComparisonValue to compute expired segments. protected final AtomicDouble _largestSeenComparisonValue; + // The TTL watermark last persisted to disk. A segment out of TTL against it has an up-to-date snapshot on disk, see + // getWatermarkToPersist(). + private volatile double _persistedWatermark; Review Comment: Can you make this variable protected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
