xiangfu0 commented on PR #19836: URL: https://github.com/apache/pinot/pull/19836#issuecomment-6207635478
Rebased onto the merged #19806 changes and retained its bulk primitive-list deserializers. f9738e798b26c145e4faa7a75f93394779717e14 clarifies the intended reserve-then-write caller, sufficient remaining space and source stability until writing finishes. `-1` means the codec cannot size without allocation, so its caller uses the legacy byte-array path; `SerializedIntermediateResult.getSize()` still requires an exact nonnegative size. The first consumer is StarTree #4759, as described in the earlier reply. I'll keep the bulk writer cutoff as the follow-up you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
