xiangfu0 commented on code in PR #19900:
URL: https://github.com/apache/pinot/pull/19900#discussion_r4291543042
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/VectorIndexHandler.java:
##########
@@ -637,7 +734,7 @@ && hasCombinedFile(indexDir, columnName, backendType)) {
}
// Delete the marker file.
- FileUtils.deleteQuietly(inProgress);
+ FileUtils.forceDelete(inProgress);
Review Comment:
Nice — this surfaces a failed marker cleanup instead of silently leaving a
stale `.inprogress` that would force a rebuild every load. Minor FYI: the text
handler's own success-path marker (TextIndexHandler:254) still uses
`deleteQuietly`, so vector is now stricter than text rather than matching it.
Not a problem (stricter is safe); just flagging the parity is inverted if you
want them aligned later.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/VectorIndexHandler.java:
##########
@@ -637,7 +734,7 @@ && hasCombinedFile(indexDir, columnName, backendType)) {
}
// Delete the marker file.
- FileUtils.deleteQuietly(inProgress);
+ FileUtils.forceDelete(inProgress);
Review Comment:
Nice — this surfaces a failed marker cleanup instead of silently leaving a
stale `.inprogress` that would force a rebuild every load. Minor FYI: the text
handler's own success-path marker (TextIndexHandler:254) still uses
`deleteQuietly`, so vector is now stricter than text rather than matching it.
Not a problem (stricter is safe); just flagging the parity is inverted if you
want them aligned later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
