siddharthteotia commented on a change in pull request #4877: Results in ResultTable if responseFormat=sql URL: https://github.com/apache/incubator-pinot/pull/4877#discussion_r353486939
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ########## @@ -28,6 +28,7 @@ import java.util.Set; import java.util.TreeMap; import java.util.function.BiFunction; +import org.apache.pinot.common.exception.QueryException; Review comment: One high level comment on this class (and I should given this during previous PR) -- as part of Javadoc, it would be very helpful to summarize the modes and their combinations and purpose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
