xiangfu0 commented on code in PR #20021:
URL: https://github.com/apache/pinot/pull/20021#discussion_r4364628733
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/manager/BaseBrokerRoutingManager.java:
##########
@@ -520,6 +535,7 @@ private void processInstanceConfigChangeInternal() {
// always contains the selected servers
for (String newDisabledInstance : newDisabledServers) {
_enabledServerInstanceMap.remove(newDisabledInstance);
+ _previouslyEnabledServers.add(newDisabledInstance);
Review Comment:
Small lifecycle concern: `newDisabledServers` here includes servers that
were *removed* from the cluster entirely (their instance config is gone), not
just disabled ones — so their id gets added to `_previouslyEnabledServers` with
the only pruning path being a later re-enable at line 475. A server that's
removed and never comes back (host replacement, renamed/ephemeral instance ids)
stays in this set forever, so it can slowly grow in clusters with churning
instance identities. Could you drop ids that are no longer present in
`instanceConfigZNRecords` at all when pruning `_enabledServerInstanceMap`? Low
impact per entry, not a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
