codecov-commenter commented on PR #20022: URL: https://github.com/apache/pinot/pull/20022#issuecomment-6377067540
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/20022?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.58904%` with `45 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.97%. Comparing base ([`910f9d5`](https://app.codecov.io/gh/apache/pinot/commit/910f9d5e4942010621c7d791557e0b4c4ffddcfd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36395c4`](https://app.codecov.io/gh/apache/pinot/commit/36395c4a46b01305bccea21eefe1b7bef9bd91fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 146 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/20022?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/pinot/core/transport/ServerChannels.java](https://app.codecov.io/gh/apache/pinot/pull/20022?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Ftransport%2FServerChannels.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvU2VydmVyQ2hhbm5lbHMuamF2YQ==) | 84.93% | [11 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/pinot/core/transport/QueryRouter.java](https://app.codecov.io/gh/apache/pinot/pull/20022?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Ftransport%2FQueryRouter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvUXVlcnlSb3V0ZXIuamF2YQ==) | 65.30% | [10 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/pinot/core/transport/AsyncQueryResponse.java](https://app.codecov.io/gh/apache/pinot/pull/20022?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Ftransport%2FAsyncQueryResponse.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvQXN5bmNRdWVyeVJlc3BvbnNlLmphdmE=) | 90.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...not/core/transport/RequestWriteTimeoutHandler.java](https://app.codecov.io/gh/apache/pinot/pull/20022?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Ftransport%2FRequestWriteTimeoutHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvUmVxdWVzdFdyaXRlVGltZW91dEhhbmRsZXIuamF2YQ==) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (910f9d5) and HEAD (36395c4). Click for more details. > > <details><summary>HEAD has 24 uploads less than BASE</summary> > >| Flag | BASE (910f9d5) | HEAD (36395c4) | >|------|------|------| >|unittests|2|1| >|java-25|6|1| >|temurin|6|1| >|lane-a|2|0| >|integration|4|0| >|integration1|2|0| >|lane-b|2|0| >|integration2|2|0| >|unittests2|1|0| ></details> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #20022 +/- ## ============================================ - Coverage 68.63% 58.97% -9.67% + Complexity 1486 1 -1485 ============================================ Files 3526 2734 -792 Lines 230143 172831 -57312 Branches 36562 28540 -8022 ============================================ - Hits 157963 101929 -56034 - Misses 59837 62256 +2419 + Partials 12343 8646 -3697 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-25](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.97% <84.58%> (-9.67%)` | :arrow_down: | | [lane-a](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [lane-b](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.97% <84.58%> (-9.67%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.97% <84.58%> (-9.66%)` | :arrow_down: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.97% <84.58%> (+0.63%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/20022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/20022?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
