xiangfu0 commented on PR #19998: URL: https://github.com/apache/pinot/pull/19998#issuecomment-6387352853
Thanks for the model and the concrete ordering. Fixed in 9e251211d1: the snapshot update marker now caches each segment maximum comparison value while its metadata is open, so the watermark cap can use it if the segment closes during the pass. The marker is published before that read so a concurrent snapshot still sees a conservative cap. If the maximum cannot be read, the unset fallback remains. BasePartitionUpsertMetadataManagerTest passed (21 tests), along with Spotless, Checkstyle, and license checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
