xiangfu0 commented on code in PR #20035:
URL: https://github.com/apache/pinot/pull/20035#discussion_r4371632138
##########
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java:
##########
@@ -353,6 +356,28 @@ public Map<ExpressionContext, ExpressionContext>
getExpressionOverrideHints() {
return _expressionOverrideHints;
}
+ /// Recompiles execution inputs after an in-place expression rewrite, before
any segment operators are built.
+ /// The original aggregation slots are retained even when formerly distinct
HAVING/ORDER-BY inputs become equal.
+ public void refreshAfterExpressionRewrite() {
Review Comment:
Minor: this is really an internal post-rewrite hook that rebuilds
aggregation state. Could it be package-private (or clearly marked internal) so
it is not invoked outside planning? Non-blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
