xiangfu0 commented on code in PR #20043:
URL: https://github.com/apache/pinot/pull/20043#discussion_r4376996252
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/JsonMatchFilterOperator.java:
##########
@@ -124,10 +124,14 @@ private ImmutableRoaringBitmap getMatchingDocIdBitmap() {
// getMatchingDocIds may return a read-only bitmap backed by the index's
(possibly memory-mapped) storage. This
// operator only iterates it (BitmapDocIdSet / BitmapCollection /
getCardinality) within the segment's acquired
// lifetime and never mutates it, so a borrowed posting list can be
consumed directly without a copy.
Review Comment:
This existing comment still says the borrowed posting list is "consumed
directly without a copy," but `limitToNumDocs` below now copies it on a
consuming segment when it holds docs >= numDocs. Worth tweaking the wording so
the two comments don't contradict each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
