xiangfu0 commented on code in PR #20040:
URL: https://github.com/apache/pinot/pull/20040#discussion_r4377006956
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -685,6 +686,17 @@ public void removePartitionGauge(final String tableName,
final int partitionId,
removeGauge(fullGaugeName);
}
+ /// Removes all partition gauges of the given gauge for the table.
+ public void removePartitionGauges(final String tableName, final G gauge) {
+ String prefix = composeTableGaugeName(tableName, gauge) + ".";
Review Comment:
Nit: when table-level metrics are disabled, `composeTableGaugeName`
collapses the name to the `allTables` bucket, so this would clear the gauge for
every table, not just this one. That matches the existing
`removeTableGauge`/`removePartitionGauge` behavior in that mode, so it's
consistent rather than a regression — just flagging it.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -949,10 +949,84 @@ private String createNewSegmentMetadata(TableConfig
tableConfig,
LOGGER.info(
"Skipping creation of new segment metadata after segment: {} during
commit. Reason: Partition ID: {} not "
+ "found in upstream metadata.", committingSegmentName,
committingSegmentPartitionGroupId);
+ if (fetchEndOfLifePartitionGroupIds(streamConfigs,
List.of(committingSegmentZKMetadata)).contains(
Review Comment:
Minor: this opens a fresh stream metadata provider and makes a synchronous
Kinesis call inside the commit path. It only fires on the terminal commit of a
partition that's already gone from upstream, so it's rare, but worth being
aware it adds latency to that one commit. No change needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
