xiangfu0 commented on code in PR #19897:
URL: https://github.com/apache/pinot/pull/19897#discussion_r4381969648
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/text/LuceneTextIndexCreator.java:
##########
@@ -57,7 +59,9 @@
/// and realtime from
[org.apache.pinot.segment.local.realtime.impl.invertedindex.RealtimeLuceneTextIndex]
public class LuceneTextIndexCreator extends AbstractTextIndexCreator {
private static final Logger LOGGER =
LoggerFactory.getLogger(LuceneTextIndexCreator.class);
- public static final String LUCENE_INDEX_DOC_ID_COLUMN_NAME = "DocID";
+ public static final String PINOT_DOC_ID_STORED_FIELD_NAME = "DocID";
+ public static final String PINOT_DOC_ID_DOC_VALUES_FIELD_NAME = "PinotDocID";
+ public static final String LUCENE_INDEX_DOC_ID_COLUMN_NAME =
PINOT_DOC_ID_STORED_FIELD_NAME;
Review Comment:
Removed the alias in
[ccb3e1a458](https://github.com/apache/pinot/commit/ccb3e1a45878cd943d5da67577c8ee3651d20d92)
and migrated all ten callers to `PINOT_DOC_ID_STORED_FIELD_NAME`. The
persisted value stays `"DocID"`; the separate multi-column creator constant is
unchanged. All 58 focused tests and affected-module checks passed.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/text/LuceneTextIndexCreator.java:
##########
@@ -57,7 +59,9 @@
/// and realtime from
[org.apache.pinot.segment.local.realtime.impl.invertedindex.RealtimeLuceneTextIndex]
public class LuceneTextIndexCreator extends AbstractTextIndexCreator {
private static final Logger LOGGER =
LoggerFactory.getLogger(LuceneTextIndexCreator.class);
- public static final String LUCENE_INDEX_DOC_ID_COLUMN_NAME = "DocID";
+ public static final String PINOT_DOC_ID_STORED_FIELD_NAME = "DocID";
+ public static final String PINOT_DOC_ID_DOC_VALUES_FIELD_NAME = "PinotDocID";
Review Comment:
Added the suggested field documentation in
[ccb3e1a458](https://github.com/apache/pinot/commit/ccb3e1a45878cd943d5da67577c8ee3651d20d92),
including the alternate numeric `"DocID"` field for a TEXT column named
`"PinotDocID"` and omission under explicit `Skip`. No runtime behavior or
stored field values changed. All 58 focused tests and affected-module checks
passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
