tarun11Mavani commented on code in PR #19776:
URL: https://github.com/apache/pinot/pull/19776#discussion_r4385287221


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/PauselessSegmentCommitter.java:
##########
@@ -28,8 +29,8 @@
 public class PauselessSegmentCommitter extends SplitSegmentCommitter {
   public PauselessSegmentCommitter(Logger segmentLogger, 
ServerSegmentCompletionProtocolHandler protocolHandler,
       SegmentCompletionProtocol.Request.Params params, SegmentUploader 
segmentUploader,
-      @Nullable String peerDownloadScheme) {
-    super(segmentLogger, protocolHandler, params, segmentUploader, 
peerDownloadScheme);
+      @Nullable String peerDownloadScheme, ServerMetrics serverMetrics) {
+    super(segmentLogger, protocolHandler, params, segmentUploader, 
peerDownloadScheme, false, serverMetrics);

Review Comment:
   I added a comment in PauselessSegmentCommitter and a line in the PR 
description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to